Charm++ parallel programming system

[Sameer Kumar <sameermanepalli AT gmail.com>]

Node groups are broken as the priority queues are not thread safe.  You are welcomed to fix that and then the restriction on the choice of the thread can be removed.

I ack. the bit-wise operators must be changed.  How do I do that? Is there a way to git --force push the change?

On Tue, Jul 18, 2017 at 1:07 AM, Phil Miller (Code Review) <charmautomation AT gmail.com> wrote:

Phil Miller posted comments on this change.

View Change

Patch set 1:

(2 comments)

• File src/conv-core/convcore.c:

  • Patch Set #1, Line 1741: if (CmiMyRank() == 0) {

    What?! Only one worker thread in each process should look at the node queue?

• File src/conv-core/converse.h:

  • Patch Set #1, Line 341: #if (CMK_BLUEGENEQ | CMK_PAMI_LINUX_PPC8) && CMK_ENABLE_ASYNC_PROGRESS

    Please use logical operators, not bit-wise

To view, visit change 2762. To unsubscribe, visit settings.

Gerrit-Project: charm

Gerrit-Branch: charm

Gerrit-MessageType: comment

Gerrit-Change-Id: I0ed295ca11bfc3030ea85dc2407bd93d995ec278

Gerrit-Change-Number: 2762

Gerrit-PatchSet: 1

Gerrit-Owner: Sameer Kumar <sameermanepalli AT gmail.com>

Gerrit-Reviewer: Charm Automation <charmplusplusautomation AT gmail.com>

Gerrit-Reviewer: Phil Miller <mille121 AT illinois.edu>

Gerrit-Comment-Date: Mon, 17 Jul 2017 19:37:07 +0000

Gerrit-HasComments: Yes