Skip to Content.
Sympa Menu

svadev - Re: [svadev] getNameStr() -> getName().str() for poolalloc and safecode

svadev AT lists.siebelschool.illinois.edu

Subject: Svadev mailing list

List archive

Re: [svadev] getNameStr() -> getName().str() for poolalloc and safecode


Chronological Thread 
  • From: John Criswell <criswell AT illinois.edu>
  • To: Matthew Wala <wala1 AT illinois.edu>
  • Cc: svadev AT cs.uiuc.edu
  • Subject: Re: [svadev] getNameStr() -> getName().str() for poolalloc and safecode
  • Date: Mon, 12 Dec 2011 13:38:33 -0600
  • List-archive: <http://lists.cs.uiuc.edu/pipermail/svadev>
  • List-id: <svadev.cs.uiuc.edu>
  • Organization: University of Illinois

On 12/12/11 1:33 PM, Matthew Wala wrote:
On Mon, Dec 12, 2011 at 10:37 AM, John
Criswell<criswell AT illinois.edu>
wrote:
On 12/11/11 9:32 PM, Randy MacLeod wrote:

I was compiling safe from llvm/clang head and fixed
the recent drppage of getNameStr(). Note that I don't know your code
and it's been a while since I looked at C++ so you should check that
what I did is correct (but you were going to do that anyway, I assume).


Was getNameStr() dropped in LLVM 3.0 or in mainline LLVM after LLVM 3.0 was
released? SAFECode and Poolalloc mainline are currently following the
release_30 branch of LLVM and aren't meant to be used with LLVM mainline.


It looks like it was dropped in mainline revision 144657 a month after
the LLVM 3.0 branch was created, but before LLVM 3.0 was released.
However Value::getNameStr() still exists in LLVM 3.0. I suppose since
Value::getName().str() and Value::getNameStr() are both supported in
LLVM 3.0, it wouldn't hurt to anticipate the changes. Just less work
to do later.

If both are supported in LLVM 3.0, then I agree; we might as well switch over now.

-- John T.


Matt

Thanks. We'll take a look at these.

-- John T.






Archive powered by MHonArc 2.6.16.

Top of Page