Svadev mailing list

[John Criswell <criswell AT illinois.edu>]

On 1/25/13 9:08 AM, Vishruth Ashok wrote:

Hey John,

Good news! Removing -Werror and -Wall worked.

But I tried reproducing the error by following the steps again and I wasn't able to.

It looks like release_32 works fine.

I've written up the bug report, but I'm not submitting it as a bug for release_30 because you said that development was frozen. Do you want me to submit it anyway, or is it not required?

Go ahead and submit the bug report.  Make sure to mention in the report that the problem is fixed in the release_32 branch of SAFECode (I guess it should even be marked "fixed").

My rationale is that 1) people are still using the release_30 branch, so knowing about faults in it and where they are fixed is useful; and 2) while development is frozen, I don't object to minor bug fixes on the release_30 branch.  I just want to avoid major changes because they're difficult to merge into more recent versions of SAFECode.

-- John T.

Regards,

Vishruth

On 24 January 2013 13:28, Vishruth Ashok <ashok2 AT illinois.edu> wrote:
Sure thing.

I re-configured poolalloc after disabling the -Werror and -Wall.

I'll retry compiling it and then file a report.

On Thursday, January 24, 2013, John Criswell wrote:
On 1/24/13 3:59 AM, Csaba Raduly wrote:
Hi,

On Wed, Jan 23, 2013 at 6:38 PM, Vishruth Ashok  wrote:
Hello,

While following the steps from here to compile poolalloc, I get an error.
I'm not exactly sure what could have gone wrong and I've tried redoing the
steps a few times, without success.

I also get an error while trying to compile safecode.
It seems related an error in Printer.cpp.

My error trace looks like this:

llvm[2]: Compiling Printer.cpp for Debug build (PIC)
In file included from Printer.cpp:23:0:
/home/vishruth/Workspace/Thesis/llvm/include/llvm/Support/GraphWriter.h: In
instantiation of ‘void
llvm::GraphWriter<GraphType>::writeNode(llvm::GraphWriter<GraphType>::NodeType*)
[with GraphType = const llvm::DSGraph*;
llvm::GraphWriter<GraphType>::NodeType = const llvm::DSNode]’:
Printer.cpp:295:19:   required from here
/home/vishruth/Workspace/Thesis/llvm/include/llvm/Support/GraphWriter.h:175:9:
error: cast from type ‘llvm::GraphWriter<const llvm::DSGraph*>::NodeType*
{aka const llvm::DSNode*}’ to type ‘void*’ casts away qualifiers
[-Werror=cast-qual]
/home/vishruth/Workspace/Thesis/llvm/include/llvm/Support/GraphWriter.h:195:9:
error: cast from type ‘llvm::GraphWriter<const llvm::DSGraph*>::NodeType*
{aka const llvm::DSNode*}’ to type ‘void*’ casts away qualifiers
[-Werror=cast-qual]
John, Isn't this already fixed?
In http://llvm.org/docs/doxygen/html/GraphWriter_8h_source.html , the
cast is to <const void*>, which should silence the warning.

It might be (provided that this version of GraphWriter is in the release_32 branch of LLVM).  I didn't investigate the details closely.

Vishruth, if you see the error in the release_32 branch on your system, can you file a bug report for it?  Fixing a warning like this is low priority as it is easy to work around, but we should have a bug report to track it.

-- John T.


Csaba

--
Vishruth Ashok
Currently pursuing Bachelor of Science
Computer Science
University of Illinois, Urbana-Champaign

--
Vishruth Ashok


Currently pursuing Bachelor of Science
Computer Science
University of Illinois, Urbana-Champaign